Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break apart ros_subscriber test translation unit #212

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Break apart ros_subscriber test translation unit #212

merged 6 commits into from
Jan 28, 2022

Conversation

mjcarroll
Copy link
Collaborator

Another attempt at reducing compilation memory usage.

Previously, building ros_subscriber.cpp used about 1.1 GB of RAM according to templight.

After splitting the individual TUs use:

image

@osrf-triage osrf-triage added this to Inbox in Core development Jan 27, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jan 27, 2022
@mjcarroll mjcarroll mentioned this pull request Jan 28, 2022
Merged
@mjcarroll mjcarroll changed the base branch from ros2 to rolling_updates January 28, 2022 17:32
@mjcarroll
Change use of deprecated declare_parameter
432d29f 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add pure virtual destructor for FactoryInterface
d685d52 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Make linters pass for Rolling
761fe91 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Break ros_subscriber test into individual TUs
169afa7 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
chapulina
chapulina approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can get rid of some includes too for extra optimization

ros_ign_bridge/test/subscribers/ros_subscriber/geometry_msgs_subscriber.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/subscribers/ros_subscriber/nav_msgs_subscriber.cpp Outdated Show resolved Hide resolved
Base automatically changed from rolling_updates to ros2 January 28, 2022 18:56
@mjcarroll
Merge branch 'ros2' into tu_testing
d8b979b
@mjcarroll
Prune headers
49be345 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 0d878e8 into ros2 Jan 28, 2022
@mjcarroll mjcarroll deleted the tu_testing branch January 28, 2022 20:14
Core development automation moved this from In review to Done Jan 28, 2022
@nuclearsandwich nuclearsandwich mentioned this pull request Jan 31, 2022
Closed
mjcarroll added a commit that referenced this pull request Feb 7, 2022
@mjcarroll
Break apart ros_subscriber test translation unit (#212)
cea776e 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll added a commit that referenced this pull request Feb 7, 2022
@mjcarroll @chapulina
[galactic] backport test memory usage improvements (#215)
3313124 
* Improve modularity of ign/ros publisher tests (#194)
* Break apart ros_subscriber test translation unit (#212)
* Fix deprecated parameter declaration

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @chapulina