Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic to Humble #275

Merged
merged 22 commits into from
Sep 23, 2022
Merged

Galactic to Humble #275

merged 22 commits into from
Sep 23, 2022

Conversation

mjcarroll
Copy link
Collaborator

@mjcarroll mjcarroll commented Jul 8, 2022 •
edited
Loading

➡️ Forward port

Port galactic to humble

Branch comparison: https://github.com/ignitionrobotics/ros_gz/compare/humble...galactic

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mjcarroll and others added 16 commits April 6, 2022 11:35
@mjcarroll
Optional "lazy" bridge subscribers (#225)
174d32a 
This allows for the bridge to be created in such a way that it is "lazy". In this case "lazy" means:
* The publication (output) side of the bridge is always on and actively looking for subscriptions.
* The subscription (input) side of the bridge is only turned on in the case that there are subscriptions on the output side.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Factory interface needs virtual destructor (#232)
629b9e8 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add Dataframe message and bridging (#239)
f08c90b 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll @ivanpauno
[galactic] Backport GuiCamera, StringVec, TrackVisual, VideoRecord (#241
315ac37 
)

* [ros_ign_interfaces] Add more interface definitions.
* Add converion functions for the added messages
* Update the factory factory function with the new messages
* Add new messages to docs
* Add test cases for the new messages conversions

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@mjcarroll
Generate boilerplate files from Python scripts (#233)
66fef24 
The way that we add factories can be a bit error-prone, as there are a lot of strings that cannot be checked at compilation time. This changes several of the boilerplate files to be generated automatically by python scripts, in line with how ros1_bridge does it.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Use the python generator for tests as well (#234)
9db97fa 
* Use the python generator for tests as well

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@caguero
Add rssi to Dataframe.msg (#249)
bdb05fe 
* Adding rssi field to ros_ign_interfaces/Dataframe.msg

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@mjcarroll
Add node component and yaml-configured bridge node (#238)
d00d74e 
* Refactor in support of adding yaml-configured node

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@chapulina @wep21
Feature: set QoS options to override durability (#250) (#259)
f0e9a25 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
@mjcarroll
Add support for converting Any <-> ParamValue (#260)
d25ae55 
* Add support for converting Any <-> ParamValue

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add ParamVec and bridge from Ignition (#261)
7dbbdf1 
* Introduces `ros_ign_interfaces::msg::ParamVec` for storing a list of Parameters that are int, bool, double, or string.
* Introduces bridge for `ignition::msgs::param` to `ros_ign_interfaces::msg::ParamVec`
* Introduces bridge for `ignition::msgs::param_v` to `ros_ign_interfaces::msg::ParamVec`

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll @ijnek
[galactic] Backport: Add std_msgs as dependency of ros_ign_gazebo (#264)
fda6daa 
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Co-authored-by: Kenji Brameld <kenjibrameld@gmail.com>
@mjcarroll @TyHowellWork
Port NavSat (#224) from ROS 1 to ROS 2 (#268)
eb27eaa 
Co-authored-by: Tyler Howell <76003804+TyHowellWork@users.noreply.github.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Fix small typo in bridge README (#270)
1114181 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Improve documentation around yaml configuration (#271)
36e7724 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Make tests faster and more robust (#272)
94abe66 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Jul 8, 2022
@chapulina chapulina moved this from Inbox to In progress in Core development Jul 8, 2022
@chapulina chapulina added the ROS 2 ROS 2 label Jul 8, 2022
ahcorde
ahcorde reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, is this ready for review ?

@mjcarroll
Copy link
Collaborator Author

CI is green, is this ready for review ?

Not quite, I'm about half way there. It's a pretty massive forward port. Will remove draft status when it is ready

andermi and others added 4 commits August 29, 2022 14:34
@andermi
Add debugger option in launch (#286)
f7f417b 
* add debugger option in launch
* remove xterm dependency; rely on x-terminal-emulator from update-alternatives

Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
Add ROS2 version of Stopwatch (#287)
574e6ac 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@j-rivero
Update supported versions to include Humble + Garden (#297)
45e69e7 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@mjcarroll
Merge branch 'galactic' into ports/galactic_to_ros2
e4f4072
@mjcarroll mjcarroll marked this pull request as ready for review September 22, 2022 23:58
@mjcarroll
Copy link
Collaborator Author

Okay, this is now ready for a review.

It's a pretty massive PR... I'm sorry, but it will bring ros2 completely up to date afaict.

@mjcarroll mjcarroll moved this from In progress to In review in Core development Sep 23, 2022
@mjcarroll
Fix merge
f1765bc 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@methylDragon
Copy link
Contributor

DCO needs fixing :O

@mjcarroll
Copy link
Collaborator Author

DCO needs fixing :O

DCO is always a bit finicky around merge commits, I'll see what I can do.

@mjcarroll
Copy link
Collaborator Author

Oh yeah, I can force DCO to pass 🤐

@mjcarroll mjcarroll force-pushed the galactic_to_ros2 branch 2 times, most recently from d3f2297 to f1765bc Compare September 23, 2022 01:38
ahcorde
ahcorde requested changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in many places ignition.msgs.foo, should we change this to gz.msgs.foo ?

ros_gz_bridge/README.md
| ros_gz_interfaces/msg/Light | ignition::msgs::Light |
| ros_gz_interfaces/msg/StringVec | ignition::msgs::StringMsg_V |
| ros_gz_interfaces/msg/TrackVisual | ignition::msgs::TrackVisual |
| rcl_interfaces/msg/ParameterValue | ignition::msgs::Any |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of ignition is gz ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the purpose of humble, we need to still maintain support for older versions with the previous set of ignition names.

I will have a follow-up PR for the final renaming bits, but that will make it so that whatever branch it lands on will only be compatible with garden forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this, yep!

@mjcarroll mjcarroll mentioned this pull request Sep 23, 2022
Closed
@mjcarroll mjcarroll changed the base branch from ros2 to humble September 23, 2022 12:39
@mjcarroll mjcarroll changed the title Galactic to ros2 Galactic to Humble Sep 23, 2022
@mjcarroll mjcarroll merged commit eeb3b03 into humble Sep 23, 2022
Core development automation moved this from In review to Done Sep 23, 2022
@mjcarroll mjcarroll deleted the galactic_to_ros2 branch September 23, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mjcarroll @methylDragon @ahcorde @chapulina @caguero @andermi @j-rivero