Make tests faster and more robust #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <michael@openrobotics.org>
9 tasks
ahcorde
approved these changes
Jun 30, 2022
mjcarroll
added a commit
that referenced
this pull request
Jul 8, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
8 tasks
mjcarroll
added a commit
that referenced
this pull request
Jul 8, 2022
Port test improvements from #272 on galactic to humble+. This should clear up some of the CI issues that we have been facing. Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Summary
I noticed that tests on galactic are slower than they have to be. I boosted the publication speed so that the tests execute faster.
Additionally, the static shared_ptr was holding up shutdown causing the test to timeout or segfault.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.