Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double wait in ros_gz_bridge #347

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix double wait in ros_gz_bridge #347

merged 1 commit into from
Jan 10, 2023

Conversation

ymd-stella
Copy link
Contributor

@ymd-stella ymd-stella commented Jan 6, 2023 •
edited
Loading

Signed-off-by: ymd-stella world.applepie@gmail.com

馃 Bug fix

Fixes #345

Summary

Remove gz::transport::waitForShutdown() from ros_gz_bridge and ros_gz_image

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ymd-stella
Fix double wait in ros_gz_bridge
ceb8898 
Signed-off-by: ymd-stella <world.applepie@gmail.com>
@osrf-triage osrf-triage added this to Inbox in Core development Jan 6, 2023
@azeey azeey self-requested a review January 9, 2023 16:52
@azeey azeey moved this from Inbox to In review in Core development Jan 9, 2023
@mjcarroll mjcarroll merged commit d13c5f3 into gazebosim:ros2 Jan 10, 2023
Core development automation moved this from In review to Done Jan 10, 2023
@ymd-stella ymd-stella deleted the fix/gz_bridge_wait branch January 10, 2023 15:43
@azeey
Copy link
Contributor

azeey commented Sep 12, 2023

We should backport this to humble and iron.

@azeey azeey self-assigned this Sep 12, 2023
ahcorde pushed a commit that referenced this pull request Sep 13, 2023
@ymd-stella @ahcorde
Fix double wait in ros_gz_bridge (#347)
9689b1e 
Signed-off-by: ymd-stella <world.applepie@gmail.com>
@ahcorde ahcorde mentioned this pull request Sep 13, 2023
Merged
8 tasks
ahcorde pushed a commit that referenced this pull request Sep 13, 2023
@ymd-stella @ahcorde
Fix double wait in ros_gz_bridge (#347)
72768bc 
Signed-off-by: ymd-stella <world.applepie@gmail.com>
@ahcorde ahcorde mentioned this pull request Sep 13, 2023
Merged
8 tasks
@ahcorde
Copy link
Collaborator

ahcorde commented Sep 13, 2023

We should backport this to humble and iron.

#449 and #450

mjcarroll pushed a commit that referenced this pull request Sep 13, 2023
@ahcorde @ymd-stella
Fix double wait in ros_gz_bridge (#347) (#450)
151d3d8 
Signed-off-by: ymd-stella <world.applepie@gmail.com>
Co-authored-by: ymd-stella <7959916+ymd-stella@users.noreply.github.com>
mjcarroll pushed a commit that referenced this pull request Sep 13, 2023
@ahcorde @ymd-stella
Fix double wait in ros_gz_bridge (#347) (#449)
e93c35d 
Signed-off-by: ymd-stella <world.applepie@gmail.com>
Co-authored-by: ymd-stella <7959916+ymd-stella@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@azeey azeey Awaiting requested review from azeey

Assignees

@azeey azeey

Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When parameter_bridge receives a SIGINT, it waits until it receives SIGINT again.
4 participants
@ymd-stella @azeey @ahcorde @mjcarroll