Add missing rosidl_cmake dep to ros_gz_bridge #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
|
@Yadunund Is this a new package on Iron ? or is this package already released on Humble ? |
clalancette
previously requested changes
May 22, 2023
There was a problem hiding this comment.
Though this would likely resolve the build warning, this isn't quite right for iron.
Instead, what should happen here is that this package should take a dependency on rosidl_pycommon, and the code in
from rosidl_pycommon import expand_template.
To answers @ahcorde's question; this deprecation is new in iron, so this should only be released into rolling and iron.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
I just pushed 158bd3b, which I think is the proper fix here. |
|
CI fixed here #395 |
ahcorde
approved these changes
May 23, 2023
mjcarroll
approved these changes
May 23, 2023
mjcarroll
pushed a commit
that referenced
this pull request
May 23, 2023
Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
mjcarroll
pushed a commit
that referenced
this pull request
May 23, 2023
Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
added a commit
that referenced
this pull request
May 23, 2023
* Add missing rosidl_cmake dep to ros_gz_bridge (#391) Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Michael Carroll <michael@openrobotics.org> * Run fortress and garden against iron Signed-off-by: Michael Carroll <michael@openrobotics.org> --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Yadu <yadunund@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://build.ros2.org/job/Ibin_ujv8_uJv8__ros_gz_bridge__ubuntu_jammy_arm64__binary/1/