-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break tus #191
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for working on this 🙇♀️ I think we aren't having issues with compilation memory for ROS 1 though, so we'll only know if this works when we port it to the ros2
branch.
// ROS messages | ||
|
||
// Ignition messages | ||
#include <ignition/msgs.hh> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing that may help compilation times is to use more targeted includes, i.e. the specific pb.h
instead of msgs.hh
.
In this specific case, I think we can even remove this include though
) | ||
|
||
set(bridge_lib | ||
ros_ign_bridge_lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI isn't happy
CMake Error at CMakeLists.txt:99 (add_library):
add_library cannot create target "ros_ign_bridge_lib" because another
target with the same name already exists. The existing target is a shared
library created in source directory
This was left over from ROS World prep and I found it when cleaning out some older workspaces. I can try to port to ROS 2 if I get some time, I just wanted to make sure it didn't get lost. |
Draft of breaking up translation units to help with memory/CPU usage of compilation.