Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix launch substitutions for ign_args #309

Merged
merged 4 commits into from Oct 12, 2022
Merged

Fix launch substitutions for ign_args #309

merged 4 commits into from Oct 12, 2022

Conversation

mjcarroll
Copy link
Collaborator

🦟 Bug fix

Fixes #308

Summary

Improves the launch file to correctly check for ign_args in addition to gz_args.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Fix launch substitutions for ign_args
be17cb8 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Oct 11, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Oct 11, 2022
@mjcarroll mjcarroll mentioned this pull request Oct 11, 2022
Closed
ahcorde
ahcorde requested changes Oct 11, 2022
View reviewed changes
ros_gz_sim/launch/gz_sim.launch.py.in Outdated Show resolved Hide resolved
ros_ign_gazebo/launch/ign_gazebo.launch.py Show resolved Hide resolved
ros_gz_sim/launch/gz_sim.launch.py.in Outdated Show resolved Hide resolved
Core development automation moved this from Inbox to In review Oct 11, 2022
@mjcarroll
Address reviewer feedback
5327ec9 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Remove extra cmake variables
8906aec 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll mentioned this pull request Oct 11, 2022
Closed
@ahcorde ahcorde merged commit f353bfb into humble Oct 12, 2022
@ahcorde ahcorde deleted the mjcarroll/fix_launch_subs branch October 12, 2022 10:08
Core development automation moved this from In review to Done Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @ahcorde