Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added light methods to Link, Root and World #1013

Merged
merged 4 commits into from
May 11, 2022
Merged

Added light methods to Link, Root and World #1013

merged 4 commits into from
May 11, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 11, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added light methods to Link, Root and World

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Added light methods to Link, Root and World
c13d9c1 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this May 11, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 11, 2022
@ahcorde ahcorde mentioned this pull request May 11, 2022
Merged
9 tasks
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1013 (031c423) into main (61c8a15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c8a15...031c423. Read the comment docs.

@ahcorde ahcorde mentioned this pull request May 11, 2022
Closed
62 tasks
azeey
azeey approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor comments

python/src/sdf/pyLink.cc Outdated Show resolved Hide resolved
python/src/sdf/pyRoot.cc Outdated Show resolved Hide resolved
python/src/sdf/pyWorld.cc Outdated Show resolved Hide resolved
@ahcorde
feeddback
07389e3 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge branch 'ahcorde/python/add_light_methods' of https://github.com…
031c423 
…/ignitionrobotics/sdformat into ahcorde/python/add_light_methods
@ahcorde ahcorde requested a review from azeey May 11, 2022 16:32
@ahcorde ahcorde merged commit 906996f into main May 11, 2022
@ahcorde ahcorde deleted the ahcorde/python/add_light_methods branch May 11, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees

@ahcorde ahcorde

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @azeey