-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sdf9 ➡️ sdf12 #1016
Merge sdf9 ➡️ sdf12 #1016
Conversation
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Updated CMakeLists and Changelog for release Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added code suggestions Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added code suggestion Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment about the CHANGELOG, code is only adding Shininess but I can see many entries, is this right ?
the changelog entries are from a978ade |
Codecov Report
@@ Coverage Diff @@
## sdf12 #1016 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 2 2
Lines 26 26
=======================================
Hits 17 17
Misses 9 9
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
➡️ Forward port
Port
sdf9
➡️sdf12
Branch comparision: sdf12...sdf9
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)