Python interfaces: Added Sensor to Link and Joint #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
62 tasks
azeey
approved these changes
May 24, 2022
| @@ -97,6 +98,22 @@ void defineJoint(pybind11::object module) | |||
| .def("semantic_pose", &sdf::Joint::SemanticPose, | |||
| "Get SemanticPose object of this object to aid in resolving " | |||
| "poses.") | |||
| .def("sensor_count", &sdf::Joint::SensorCount, | |||
| "Get the number of sensors.") | |||
| .def("sensor_by_index", &sdf::Joint::SensorByIndex, | |||
There was a problem hiding this comment.
This made me realize we don't have mutable versions of Joint::SensorByIndex and Joint::SensorByName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Related with this meta-ticket #931
Sensor is merged, we can include sensor methods in Links and Joints
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.