Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmosphere: update calls to use sdf::Errors output #1161

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 20, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on #1141.

Summary

Adds missing Errors structure parameters in a few methods of the Atmosphere class.

Test it

Using the Atmosphere class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Marco A. Gutierrez added 2 commits October 3, 2022 16:48
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the base branch from main to sdf13 October 3, 2022 16:48
@marcoag marcoag force-pushed the marcoag/sdf_error_atmosphere branch from 6e2051d to 1b1f353 Compare October 3, 2022 16:49
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1161 (5a6fa07) into sdf13 (ac45020) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5a6fa07 differs from pull request most recent head f0cbdc6. Consider uploading reports for the commit f0cbdc6 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1161   +/-   ##
=======================================
  Coverage   87.53%   87.54%           
=======================================
  Files         126      126           
  Lines       16446    16453    +7     
=======================================
+ Hits        14396    14403    +7     
  Misses       2050     2050           
Impacted Files Coverage Δ
src/Atmosphere.cc 93.54% <100.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcoag marcoag changed the title Atmosphere: update calls to use sdf::Errors parameters Atmosphere: update calls to use sdf::Errors output Mar 29, 2023
@marcoag marcoag merged commit b19b14d into sdf13 Mar 29, 2023
@marcoag marcoag deleted the marcoag/sdf_error_atmosphere branch March 29, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants