Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when ignoring urdf links due to small masses or no inertia defined #1230

Closed
wants to merge 3 commits into from

Conversation

aaronchongth
Copy link
Collaborator

🦟 Bug fix

Related to #199 and #1007.

Summary

  • Promote sdfdbg calls when ignoring urdf links with small masses or no inertia, to sdfwarn
  • Make warnings more verbose, whether inertia was not defined, or mass was too small
  • Added tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Feb 8, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1230 (57d3732) into sdf9 (783818a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 57d3732 differs from pull request most recent head b323657. Consider uploading reports for the commit b323657 to get more accurate results

@@            Coverage Diff             @@
##             sdf9    #1230      +/-   ##
==========================================
+ Coverage   88.35%   88.44%   +0.08%     
==========================================
  Files          63       63              
  Lines       10093    10102       +9     
==========================================
+ Hits         8918     8935      +17     
+ Misses       1175     1167       -8     
Impacted Files Coverage Δ
src/parser_urdf.cc 85.75% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaronchongth aaronchongth marked this pull request as draft February 8, 2023 06:40
@aaronchongth
Copy link
Collaborator Author

Closing to implement changes to sdf12 before considering backporting to sdf9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant