Fix camera_info_topic default value #1241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The
<camera_info_topic>
default value was set to__default__
in sdf 1.7 in #1201. However, these changes were not forward ported to sdf 1.8, 1.9. Ran into this bug as it caused a test failure in gz-sensors6 when I tried to forward port gz-sensors3 to 6 in gazebosim/gz-sensors#327.I believe
__default__
should be the correct value since the code specifically looks for this string: https://github.com/gazebosim/sdformat/blob/sdf12/src/Camera.cc#L263Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.