Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera_info_topic default value #1241

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fix camera_info_topic default value #1241

merged 1 commit into from
Feb 28, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 27, 2023

🦟 Bug fix

Summary

The <camera_info_topic> default value was set to __default__ in sdf 1.7 in #1201. However, these changes were not forward ported to sdf 1.8, 1.9. Ran into this bug as it caused a test failure in gz-sensors6 when I tried to forward port gz-sensors3 to 6 in gazebosim/gz-sensors#327.

I believe __default__ should be the correct value since the code specifically looks for this string: https://github.com/gazebosim/sdformat/blob/sdf12/src/Camera.cc#L263

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Feb 27, 2023
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1241 (13a6ac9) into sdf12 (4121eaf) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 13a6ac9 differs from pull request most recent head 5654e2a. Consider uploading reports for the commit 5654e2a to get more accurate results

@@           Coverage Diff           @@
##            sdf12    #1241   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files          79       79           
  Lines       13090    13090           
=======================================
+ Hits        12046    12047    +1     
+ Misses       1044     1043    -1     
Impacted Files Coverage Δ
src/Camera.cc 89.64% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Feb 27, 2023
@ahcorde ahcorde merged commit f23fac7 into sdf12 Feb 28, 2023
Core development automation moved this from In review to Done Feb 28, 2023
@ahcorde ahcorde deleted the camera_info_default branch February 28, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants