Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera_info_topic default value in sdf 1.10 #1247

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 4, 2023

🦟 Bug fix

Summary

Applies the same fix done in #1241 to sdf 1.10

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 4, 2023
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1247 (b8887a0) into sdf13 (0c46f82) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b8887a0 differs from pull request most recent head 8d7b804. Consider uploading reports for the commit 8d7b804 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1247   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         126      126           
  Lines       16248    16248           
=======================================
+ Hits        14219    14220    +1     
+ Misses       2029     2028    -1     
Impacted Files Coverage Δ
src/Camera.cc 89.64% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 34eb5c0 into sdf13 Mar 6, 2023
@scpeters scpeters deleted the camera_info_default_1.10 branch March 6, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants