Change behavior of Param::Get<bool> #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Implements a behavior change from a TODO comment in the Fortress era
Summary
A comment was added in d353294 to #638 suggesting a behavior change in
Param::Get<bool>
that should be done for Fortress. I just noticed it recently and have implemented the behavior change and updated a test and the migration guide.Description of behavior change:
Previously when a Param was set from a string, the
Get<bool>
method would always returntrue
, andthe value would be
true
if the lowercase value stringmatched
"1"
or"true"
. Otherwise the value wouldbe
false
.Now, the
Get<bool>
method returnstrue
only if thelowercase value string matches one of
"0"
,"1"
,"true"
, or"false"
. OtherwiseGet<bool>
returnsfalse
and the value is not written.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.