Adding comment and modifications to element_tracing test regarding path sanitization #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th sanitization Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
force-pushed
the
aaron/show-path-sanitization-error
branch
from
e9d1a19
to
6aaa2d8
Compare
jennuine
approved these changes
May 24, 2021
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Chong aaronchongth@gmail.com
🦟 Bug fix
Related to #572
Summary
This modifies an integration test for
element_tracing, highlighting the issue #572, for Windows machines, and adding a comment that explains the change in the test.Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge