Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triage, remove ticket templates #608

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add triage, remove ticket templates #608

merged 1 commit into from
Jun 29, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Test it

After this is in, new tickets will show up at the inbox, and the ticket templates will be pulled from the org.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Code check passed (In source directory, run sh tools/code_check.sh)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine June 28, 2021 23:34
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jun 28, 2021
Copy link
Collaborator

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should this target sdf9 then ported to sdf11?

@chapulina
Copy link
Contributor Author

should this target sdf9 then ported to sdf11

I almost did that initially, but I think that it only picks up the default branch, which is sdf11 at the moment, so I think it's enough to merge forward from here.

@chapulina
Copy link
Contributor Author

@osrf-jenkins run tests?

@chapulina
Copy link
Contributor Author

I enabled the DCO bot after this PR was open. Let's merge without that check for now, reopening the PR would trigger lots of builds.

@chapulina chapulina merged commit 3b7ecc0 into sdf11 Jun 29, 2021
@chapulina chapulina deleted the chapulina/infra branch June 29, 2021 02:45
chapulina added a commit that referenced this pull request Jun 30, 2021
* Add triage, remove ticket templates (#608)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Fix ABI break on sdf11 (#606)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* 🎈 11.2.1 (#609)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>

* Fix segfault when checking for required elements in joint (#610)

* Used xml instead of elemXml, added test for this particular case

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
@chapulina chapulina mentioned this pull request Aug 18, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants