Fix segfault when checking for required elements in joint #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchongth
changed the title
azeey
approved these changes
Jun 29, 2021
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
force-pushed
the
aaron/fix_590
branch
from
1c79f2f
to
0344644
Compare
chapulina
added a commit
that referenced
this pull request
Jun 30, 2021
* Add triage, remove ticket templates (#608) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix ABI break on sdf11 (#606) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * 🎈 11.2.1 (#609) Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> * Fix segfault when checking for required elements in joint (#610) * Used xml instead of elemXml, added test for this particular case Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Chong aaronchongth@gmail.com
🦟 Bug fix
Fixes #590
Summary
xml->GetLineNum()instead ofelemXml->GetLineNum()Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge