Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aded ToElement conversion for shapes #772

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Aded ToElement conversion for shapes #772

merged 3 commits into from
Dec 6, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 3, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds ToElement conversions for the Physics and Atmosphere DOM objects.

Test it

Run the tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Dec 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #772 (7775c07) into sdf12 (3d8147b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #772      +/-   ##
==========================================
+ Coverage   89.23%   89.30%   +0.06%     
==========================================
  Files          76       76              
  Lines       12081    12160      +79     
==========================================
+ Hits        10781    10860      +79     
  Misses       1300     1300              
Impacted Files Coverage Δ
src/Box.cc 91.66% <100.00%> (+1.66%) ⬆️
src/Capsule.cc 96.07% <100.00%> (+0.72%) ⬆️
src/Cylinder.cc 96.07% <100.00%> (+0.72%) ⬆️
src/Ellipsoid.cc 91.66% <100.00%> (+1.66%) ⬆️
src/Heightmap.cc 100.00% <100.00%> (ø)
src/Mesh.cc 98.55% <100.00%> (+0.36%) ⬆️
src/Plane.cc 92.00% <100.00%> (+1.52%) ⬆️
src/Sphere.cc 91.66% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8147b...7775c07. Read the comment docs.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@nkoenig nkoenig enabled auto-merge (squash) December 6, 2021 18:35
@scpeters
Copy link
Member

scpeters commented Dec 6, 2021

we ran into some questions about the design of DOM objects about a year ago and posted some of them in #292. Here are two of those questions that seem relevant to this work:

  • How dynamic is the DOM? If you call SetPoseRelativeTo, does that modify the embedded ElementPtr? the PoseRelativeToGraph?
  • Is the DOM a read-only interface to a model parsed from XML? Or would you construct a model programmatically from DOM objects?

cc @azeey

@nkoenig nkoenig merged commit 520b74f into sdf12 Dec 6, 2021
@nkoenig nkoenig deleted the shape_toelement branch December 6, 2021 19:33
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants