-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdf -> usd converter: add joints #837
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #837 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 78 78
Lines 12636 12636
=======================================
Hits 11484 11484
Misses 1152 1152 Continue to review full report at Codecov.
|
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
94c6b51
to
68a9458
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
…rapped sdf errors Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
992ab59
to
f1b82d6
Compare
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
can you resolve the conflicts? |
@osrf-jenkins retest this please |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some code to address the feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only two minor comments remaining
I still don't get the Y-axis revolute joint issue, but there are todo comments there, so we can come back to it at some point
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Sounds good, @ahcorde may have some more info about this - I left a comment with some more background/context: #837 (comment) All other feedback should be addressed now, so this is ready for final review. |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
🎉 New feature
Summary
Adds support for converting joints to their USD representation when parsing a SDF model to USD. Currently, the following joint types are supported:
Test it
You can run the unit test that has been added (
sdformat/usd/src/sdf_parser/Joint_Sdf2Usd_TEST.cc
)Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.