Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make computeMergedModelProxyFrameName public #868

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Mar 7, 2022

🎉 New feature

Summary

This function may be used by downstream applications (e.g. applications
that utilize the Interface API) to determine the name of the proxy frame
created for a merged model.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This function may be used by downstream applications (e.g. applications
that utilize the Interface API) to determine the name of the proxy frame
created for a merged model.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner March 7, 2022 21:47
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #868 (e80ace1) into sdf12 (c496c5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #868   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          92       92           
  Lines       14222    14222           
=======================================
  Hits        12588    12588           
  Misses       1634     1634           
Impacted Files Coverage Δ
src/Utils.cc 83.33% <ø> (-0.24%) ⬇️
src/Utils.hh 94.73% <ø> (ø)
src/parser.cc 87.57% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c496c5b...e80ace1. Read the comment docs.

@azeey azeey requested a review from jennuine March 7, 2022 23:40
@azeey azeey enabled auto-merge (squash) March 9, 2022 00:09
@azeey azeey merged commit 41c4920 into gazebosim:sdf12 Mar 9, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants