Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD to SDF: Returned errors in USDWorld #896

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 22, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Return errors in USDWorld

Checklist

  • Signed all commits for DCO
  • [] Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the usd label Mar 22, 2022
@ahcorde ahcorde requested a review from adlarkin March 22, 2022 09:43
@ahcorde ahcorde requested a review from azeey as a code owner March 22, 2022 09:43
@ahcorde ahcorde self-assigned this Mar 22, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner March 22, 2022 09:43
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #896 (d0f14cf) into sdf12 (0eea69f) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##            sdf12     #896      +/-   ##
==========================================
- Coverage   88.16%   88.11%   -0.06%     
==========================================
  Files         100      100              
  Lines       14644    14652       +8     
==========================================
- Hits        12911    12910       -1     
- Misses       1733     1742       +9     
Impacted Files Coverage Δ
usd/src/usd_parser/USDWorld.cc 70.00% <66.66%> (-3.08%) ⬇️
usd/src/usd_parser/USDMaterial.cc 63.87% <100.00%> (-1.03%) ⬇️
usd/src/usd_parser/USDData.cc 63.55% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eea69f...d0f14cf. Read the comment docs.

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 23, 2022

@osrf-jenkins retest this please

@ahcorde ahcorde merged commit a905f0c into sdf12 Mar 23, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf/fix_world_errors branch March 23, 2022 11:41
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants