Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-aliasing element for <camera><image> #909

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

WilliamLewww
Copy link
Contributor

@WilliamLewww WilliamLewww commented Mar 24, 2022

🎉 Anti-aliasing element for <camera><image>

Related pull requests:

Summary

Adds the <anti_aliasing> element to <camera><image>.

Anti-aliasing is always associated with a value (usually for the filter size).
<anti_aliasing> is the value that will be used by the anti-aliasing type.

When engines continue to support different anti-aliasing types (currently OGRE1 and OGRE2 only use MSAA), an attribute (type="MSAA") can be added to the element.

<camera name="camera">
  <image>
    <width>640</width>
    <height>480</height>
    <format>R8G8B8</format>
    <anti_aliasing>4</anti_aliasing>
  </image>
...
</camera>

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Mar 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #909 (72f5aca) into sdf9 (41ad073) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 72f5aca differs from pull request most recent head 08f0bdd. Consider uploading reports for the commit 08f0bdd to get more accurate results

@@           Coverage Diff           @@
##             sdf9     #909   +/-   ##
=======================================
  Coverage   87.56%   87.57%           
=======================================
  Files          63       63           
  Lines        9894     9901    +7     
=======================================
+ Hits         8664     8671    +7     
  Misses       1230     1230           
Impacted Files Coverage Δ
src/Camera.cc 81.60% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ad073...08f0bdd. Read the comment docs.

@ahcorde ahcorde merged commit 72b77c2 into gazebosim:sdf9 Mar 29, 2022
This was referenced Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants