Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added equality operators to Plugin #912

Merged
merged 8 commits into from
Apr 21, 2022
Merged

Added equality operators to Plugin #912

merged 8 commits into from
Apr 21, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 25, 2022

🎉 New feature

Added operator== and operator!= to the Plugin class.

Test it

Added a new unit test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 2 commits March 25, 2022 09:45
Added convenience constructor to plugin
6f94339 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Added equality operators to Plugin
fea4182 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Mar 25, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Mar 25, 2022
@chapulina chapulina added the 🏯 fortress Ignition Fortress label Mar 25, 2022
Base automatically changed from plugin_constructor to sdf12 April 4, 2022 18:35
Nate Koenig added 2 commits April 4, 2022 11:40
Merged with sdf12
1d178aa 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Remove common dependency
ab10f10 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina requested a review from ahcorde April 4, 2022 18:46
chapulina
chapulina approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass

src/Plugin_TEST.cc Outdated Show resolved Hide resolved
Nate Koenig added 2 commits April 21, 2022 08:33
Merge branch 'sdf12' into plugin_equality
f314d45
Fixed test
7424ff6 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov-commenter
Copy link

Codecov Report

Merging #912 (7424ff6) into sdf12 (1902c16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf12     #912   +/-   ##
=======================================
  Coverage   65.38%   65.38%           
=======================================
  Files           2        2           
  Lines          26       26           
=======================================
  Hits           17       17           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1902c16...7424ff6. Read the comment docs.

@nkoenig nkoenig merged commit 12e7782 into sdf12 Apr 21, 2022
@nkoenig nkoenig deleted the plugin_equality branch April 21, 2022 17:58
Core development automation moved this from In review to Done Apr 21, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
chapulina added a commit that referenced this pull request May 9, 2022
@chapulina @ahcorde
@adlarkin @nkoenig
12 ➡️ 13 (main) (#1009)
f3c2704 
* USD to SDF: Added Lights attached to models (#903)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>

* USD to SDF: Added diff drive plugin (#904)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>

* USD to SDF: some fixes (#991)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added equality operators to Plugin (#912)

* Added convenience constructor to plugin

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added equality operators to Plugin

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Remove common dependency

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fixed test

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nkoenig @codecov-commenter @chapulina @ahcorde