Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USD to SDF: Added diff drive plugin #904

Merged
merged 154 commits into from
Apr 19, 2022
Merged

USD to SDF: Added diff drive plugin #904

merged 154 commits into from
Apr 19, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 22, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

USD to SDF: Added diff drive plugin

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

ahcorde and others added 30 commits March 9, 2022 13:22
@ahcorde
USD -> SDF: Added cmd line tool
48c499b 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
USD -> SDF: Parse Physics and generated SDF file
3a9b349 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
usd -> sdf: Read transforms
576f9bd 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
USD -> SDF: Added lights attached to the world
d10b6ec 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed var name
a869404 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added tests
0d2f1ae 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed build and added USDLight test
4b09785 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@adlarkin
review feedback
d939ca4 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
more review feedback
bffdc8f 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@ahcorde
Merge remote-tracking branch 'origin/sdf12' into ahcorde/usd_to_sdf_p…
213fb64 
…hysics
@ahcorde
feedback
460d693 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_physics' into…
866ba4f 
… ahcorde/usd_to_sdf_transforms
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_transforms' i…
3dd8022 
…nto ahcorde/usd_to_sdf_lights
@ahcorde
USD -> SDF: Added model tag
840088b 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fix when physics schema is not available
a01e4f9 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
USD -> SDF: Added link tag
a051214 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@adlarkin
review feedback
318eff9 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
fix test
602a176 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@ahcorde
Added some feedback
2ba1b26 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added feedback
d8212ae 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added feedback
50eabdb 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_physics' into…
fea108f 
… ahcorde/usd_to_sdf_transforms
@ahcorde
Added feedback
539d724 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_transforms' i…
1f4f124 
…nto ahcorde/usd_to_sdf_lights
@ahcorde
Removed WorldInterface class
faafcdd 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_physics' into…
8dbabfb 
… ahcorde/usd_to_sdf_transforms
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_transforms' i…
f1b85ae 
…nto ahcorde/usd_to_sdf_lights
@ahcorde
fixed test
5f754dc 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_physics' into…
42647f9 
… ahcorde/usd_to_sdf_transforms
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_transforms' i…
952099e 
…nto ahcorde/usd_to_sdf_lights
ahcorde and others added 18 commits April 13, 2022 15:01
@ahcorde
Fixed test
5f5919b 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@adlarkin
review feedback
85ce7f6 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_joints' into …
b85bbd8 
…ahcorde/usd_to_sdf_sensors
@ahcorde
Merge remote-tracking branch 'origin/sdf12' into ahcorde/usd_to_sdf_s…
a43b2f0 
…ensors
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_sensors' into…
51563bc 
… ahcorde/usd_to_sdf_link_lights
@adlarkin
review feedback
6c281de 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_sensors' into…
77ada72 
… ahcorde/usd_to_sdf_link_lights
@ahcorde
make linters happy
3b1d3ad 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Fixed tests
c64fc3d 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/usd_to_sdf_sensors' into…
0ed046c 
… ahcorde/usd_to_sdf_link_lights
@adlarkin
Merge branch 'sdf12' into ahcorde/usd_to_sdf_link_lights
0099fe0
@adlarkin
review feedback
238ee64 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
add tests
7a4ce0a 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
fix tests
72a9eec 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
make tests more robust
a897ad8 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
Merge branch 'sdf12' into ahcorde/usd_to_sdf_link_lights
ab60b1a
@adlarkin
Merge branch 'ahcorde/usd_to_sdf_link_lights' into ahcorde/usd_to_sdf…
b9e04dc 
…_diff_drive_plugin

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin
allow usage of gazebo plugins to be set at command line
4d4292c 
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
adlarkin
adlarkin approved these changes Apr 15, 2022
View reviewed changes
usd/src/usd_parser/USDWorld.cc Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #904 (cb54e9c) into sdf12 (2247225) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf12     gazebosim/sdformat#904   +/-   ##
=======================================
  Coverage   65.38%   65.38%           
=======================================
  Files           2        2           
  Lines          26       26           
=======================================
  Hits           17       17           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2247225...cb54e9c. Read the comment docs.

@adlarkin adlarkin mentioned this pull request Jul 29, 2022
Open
Base automatically changed from ahcorde/usd_to_sdf_link_lights to sdf12 April 19, 2022 07:44
@ahcorde ahcorde marked this pull request as ready for review April 19, 2022 13:28
@ahcorde ahcorde merged commit a593db2 into sdf12 Apr 19, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf_diff_drive_plugin branch April 19, 2022 13:29
chapulina added a commit that referenced this pull request May 9, 2022
@chapulina @ahcorde
@adlarkin @nkoenig
12 ➡️ 13 (main) (#1009)
f3c2704 
* USD to SDF: Added Lights attached to models (#903)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>

* USD to SDF: Added diff drive plugin (#904)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>

* USD to SDF: some fixes (#991)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added equality operators to Plugin (#912)

* Added convenience constructor to plugin

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added equality operators to Plugin

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Remove common dependency

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fixed test

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey left review comments

@scpeters scpeters scpeters left review comments

@adlarkin adlarkin adlarkin approved these changes

Assignees

@ahcorde ahcorde

Labels
usd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahcorde @codecov-commenter @azeey @scpeters @adlarkin