Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OutputConfig #918

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Added OutputConfig #918

merged 3 commits into from
Mar 29, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 28, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds an OutputConfig class to control ToElement and other output configurations.

Test it

The tests have been updated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@azeey
Copy link
Collaborator

azeey commented Mar 28, 2022

OutputConfig.hh is missing.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 28, 2022
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #918 (8788d1c) into sdf12 (e8de24e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf12     #918   +/-   ##
=======================================
  Coverage   88.05%   88.06%           
=======================================
  Files         100      101    +1     
  Lines       14696    14702    +6     
=======================================
+ Hits        12941    12947    +6     
  Misses       1755     1755           
Impacted Files Coverage Δ
src/ParserConfig.cc 100.00% <ø> (ø)
src/Model.cc 92.72% <100.00%> (ø)
src/OutputConfig.cc 100.00% <100.00%> (ø)
src/Root.cc 95.12% <100.00%> (ø)
src/World.cc 95.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8de24e...8788d1c. Read the comment docs.

@scpeters scpeters merged commit 965f3b5 into sdf12 Mar 29, 2022
@scpeters scpeters deleted the output_config branch March 29, 2022 17:01
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants