Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Error Python interface #933

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Added Error Python interface #933

merged 7 commits into from
Apr 5, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 4, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Error Python interface

Test it

from sdformat import Error

error = Error(Error.FILE_READ, "Unable to read a file")
print(error.message())
print(error.code())

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 4, 2022
@ahcorde ahcorde self-assigned this Apr 4, 2022
@ahcorde ahcorde mentioned this pull request Apr 4, 2022
62 tasks
@osrf-triage osrf-triage added this to Inbox in Core development Apr 4, 2022
@chapulina chapulina added mujoco 🌱 garden Ignition Garden labels Apr 5, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Apr 5, 2022
python/src/sdf/Error.hh Outdated Show resolved Hide resolved
python/src/sdf/Error.hh Outdated Show resolved Hide resolved
python/src/sdf/Error.cc Outdated Show resolved Hide resolved
python/src/sdf/_ignition_sdformat_pybind11.cc Outdated Show resolved Hide resolved
Base automatically changed from ahcorde/python/basic_structure to main April 5, 2022 20:34
@ahcorde ahcorde requested a review from azeey April 5, 2022 20:51
python/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #933 (010c2aa) into main (266d452) will decrease coverage by 0.02%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.03%     
==========================================
  Files         100      102       +2     
  Lines       14637    14706      +69     
==========================================
+ Hits        12905    12962      +57     
- Misses       1732     1744      +12     
Impacted Files Coverage Δ
python/src/sdf/pyError.cc 81.53% <81.53%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266d452...010c2aa. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) April 5, 2022 22:36
@ahcorde ahcorde merged commit 6c9b4ad into main Apr 5, 2022
@ahcorde ahcorde deleted the ahcorde/python/error branch April 5, 2022 22:39
Core development automation moved this from In review to Done Apr 5, 2022
{
return self == true;
},
"Sets the XML path that is associated with this error.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc-string is incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants