Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Light Python interface #989

Merged
merged 5 commits into from
May 11, 2022
Merged

Added Light Python interface #989

merged 5 commits into from
May 11, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 18, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Light Python interface

Test it

from sdformat import Light

light = Light()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Added Light Python interface
3ce4ad1 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 18, 2022
@ahcorde ahcorde self-assigned this Apr 18, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 18, 2022
@ahcorde ahcorde mentioned this pull request Apr 18, 2022
Closed
62 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022 •
edited
Loading

Codecov Report

Merging #989 (fc332f0) into main (bb84733) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb84733...fc332f0. Read the comment docs.

@ahcorde ahcorde mentioned this pull request May 10, 2022
Merged
9 tasks
azeey
azeey approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments

python/test/pyLight_TEST.py Outdated
class LightColor(unittest.TestCase):

def test_default_construction(self):
light = Light()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent with 4 spaces

python/test/pyLight_TEST.py Outdated
self.assertFalse(semanticPose.relative_to())
pose = Pose3d()
# expect errors when trying to resolve pose
self.assertTrue(semanticPose.resolve(pose))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using len for errors for clarity

python/test/pyLight_TEST.py Outdated
self.assertEqual("world", semanticPose.relative_to())
pose = Pose3d()
# expect errors when trying to resolve pose
self.assertTrue(semanticPose.resolve(pose))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using len for errors for clarity

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #989 (4f70c2c) into main (f3c2704) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f70c2c differs from pull request most recent head e67996d. Consider uploading reports for the commit e67996d to get more accurate results

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c2704...e67996d. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) May 10, 2022 22:14
@azeey azeey disabled auto-merge May 11, 2022 01:33
@azeey
Copy link
Collaborator

azeey commented May 11, 2022

All the commits are signed, but it seems like the DCO bot is not running. I'll override and merge.

@azeey azeey merged commit 71dee43 into main May 11, 2022
@azeey azeey deleted the ahcorde/python/light branch May 11, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

@ahcorde ahcorde

Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @codecov-commenter @azeey