-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Scene Python interfaace #992
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
===========================================
+ Coverage 66.66% 83.42% +16.75%
===========================================
Files 2 149 +147
Lines 27 18445 +18418
===========================================
+ Hits 18 15388 +15370
- Misses 9 3057 +3048
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor issues.
python/test/pyScene_TEST.py
Outdated
import unittest | ||
|
||
|
||
class RootTEST(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class RootTEST(unittest.TestCase): | |
class SceneTEST(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python/test/pyScene_TEST.py
Outdated
self.assertEqual(Color(0.1, 0.2, 0.3), scene.ambient()) | ||
|
||
scene.set_background(Color(0.1, 0.2, 0.3)) | ||
self.assertEqual(Color(0.1, 0.2, 0.3), scene.ambient()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.assertEqual(Color(0.1, 0.2, 0.3), scene.ambient()) | |
self.assertEqual(Color(0.1, 0.2, 0.3), scene.background()) |
Should also change this in Scene_TEST.cc
. I would also suggest changing the
color values so the test fails if the wrong function is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
This PR is part of this mete ticket #931
Summary
Added Scene Python interface
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.