stracktrie: use pooling, less allocs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Sep 3, 2020
| // Add new child | ||
| if st.children[idx] == nil { | ||
| st.children[idx] = stackTrieFromPool(st.db) | ||
| st.children[idx].keyOffset = st.keyOffset + 1 |
gballet
reviewed
Sep 3, 2020
| st.children[idx] = NewStackTrie(st.db) | ||
| st.children[idx].keyOffset = st.keyOffset + 1 | ||
| } | ||
| // Unresolve elder siblings |
There was a problem hiding this comment.
I would prefer "hash" to "unresolve"
|
Reason for moving it is that hashing siblings may free up some nodes that can be reused for the new insertion.
|
gballet
added a commit
that referenced
this pull request
Sep 24, 2020
core/types: use stacktrie for derivesha trie: add stacktrie file trie: fix linter core/types: use stacktrie for derivesha rebased: adapt stacktrie to the newer version of DeriveSha Co-authored-by: Martin Holst Swende <martin@swende.se> More linter fixes review feedback: no key offset for nodes converted to hashes trie: use EncodeRLP for full nodes core/types: insert txs in order in derivesha trie: tests for derivesha with stacktrie trie: make stacktrie use pooled hashers trie: make stacktrie reuse tmp slice space trie: minor polishes on stacktrie trie/stacktrie: less rlp dancing core/types: explain the contorsions in DeriveSha ci: fix goimport errors trie: clear mem on subtrie hashing squashme: linter fix stracktrie: use pooling, less allocs (#3) trie: in-place hex prefix, reduce allocs and add rawNode.EncodeRLP Reintroduce the `[]node` method, add the missing `EncodeRLP` implementation for `rawNode` and calculate the hex prefix in place. Co-authored-by: Martin Holst Swende <martin@swende.se>
gballet
added a commit
that referenced
this pull request
Oct 3, 2020
core/types: use stacktrie for derivesha trie: add stacktrie file trie: fix linter core/types: use stacktrie for derivesha rebased: adapt stacktrie to the newer version of DeriveSha Co-authored-by: Martin Holst Swende <martin@swende.se> More linter fixes review feedback: no key offset for nodes converted to hashes trie: use EncodeRLP for full nodes core/types: insert txs in order in derivesha trie: tests for derivesha with stacktrie trie: make stacktrie use pooled hashers trie: make stacktrie reuse tmp slice space trie: minor polishes on stacktrie trie/stacktrie: less rlp dancing core/types: explain the contorsions in DeriveSha ci: fix goimport errors trie: clear mem on subtrie hashing squashme: linter fix stracktrie: use pooling, less allocs (#3) trie: in-place hex prefix, reduce allocs and add rawNode.EncodeRLP Reintroduce the `[]node` method, add the missing `EncodeRLP` implementation for `rawNode` and calculate the hex prefix in place. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
gballet
added a commit
that referenced
this pull request
Mar 15, 2024
regenerate posdao contract bindings more build fixes more build fixes more build fixes fix simple name fix more build errors 39 build errors to go! fix build add chiado chainspec start import from #3 forkid hack genesis init base fee collector only apply max code size check after shanghai handshake hack add bootnodes to list add TTD + banner info fix: create the correct genesis fix: duplicate field a few bug fixes found during my tests more error fixes fixes to run through up to 6M blocks and counting fix eip1559FeeCollector location in config config fix + support post london free txs fix contract rewrite decoding fix resume-time panic when still in aura mode speedup: hardcode forkblock to determine if pos is active add withdrawals contract to config add cancun time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduces the allocs and allocated bytes (heap allocs) quite substantially.
But I figured I'd rather make it as a PR than push to your branch, because the changes might be 'ugly' ...