Basic CI Testing #24
Merged
Basic CI Testing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just runs the file through rgbasm to make sure the syntax is correct and there aren't any errors.
ISSOtm
reviewed
Mar 22, 2022
There was a problem hiding this comment.
The idea is good—we probably should have done this a while ago, tbf.
I'm iffy on building RGBDS from source, as then this workflow depends on their build deps. I think ideally we should run on macOS (brew) and on Windows (release distributable), since those two have binary distributions, and should test LF vs. CRLF handling.
ISSOtm
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just runs the file through rgbasm to make sure the syntax is correct and there aren't any errors.