Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asymmetric VRAM Tile Data example #559

Open
nummacway opened this issue Jul 3, 2024 · 2 comments
Open

Use asymmetric VRAM Tile Data example #559

nummacway opened this issue Jul 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nummacway
Copy link

Both bytes' bit patterns in the current example for VRAM Tile Data are symmetric. This can be ambiguous concerning the bit order. If one is not exactly sure about the bit order, one cannot understand the example. The bytes in the last two rows of the example image are both asymmetric and would therefore make a better example.

Because I am not sure about the bit order, I cannot fix this myself. Thanks to anyone who does.

@pinobatch
Copy link
Member

You could adapt the ½ fraction example from NESdev.
nugg

@ISSOtm
Copy link
Member

ISSOtm commented Jul 4, 2024

Thank you for pointing that out! I think Pino's suggestion is very good too.

Is the bit order not explained by the text? Is the description unclear? If either of these can be answered “yes”, IMO that's worth fixing too.

Regardless, the bit order is bit 7 = leftmost pixel. If you feel able to fix this yourself, that would be lovely and appreciated! ^^

@avivace avivace added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants