Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort .sym files in ascending order, and test for it #1355

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Mar 13, 2024

This should fix #1356.

I had switched from qsort to std::stable_sort without noticing that the latter takes a boolean less-than comparator, instead of a -1/0/1 ordering comparator.

@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! tests This affects the test suite rgblink This affects RGBLINK labels Mar 13, 2024
@Rangi42 Rangi42 added this to the v0.7.1 milestone Mar 13, 2024
@Rangi42 Rangi42 changed the title Test that .sym files are sorted as expected Sort .sym files in ascending order, and test for it Mar 13, 2024
@Rangi42 Rangi42 merged commit 8ec0d01 into gbdev:master Mar 13, 2024
22 of 24 checks passed
@Rangi42 Rangi42 deleted the sym-sort branch March 13, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgblink This affects RGBLINK tests This affects the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.sym files are not sorted in ascending order
1 participant