Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Interpretation remarks definition #5

Closed
cgendreau opened this issue Jan 13, 2017 · 1 comment
Closed

Improve Interpretation remarks definition #5

cgendreau opened this issue Jan 13, 2017 · 1 comment
Assignees
@cgendreau

Comments

@cgendreau
Copy link
Contributor

Interpretation remarks are also known as "issues" (e.g. OccurrenceIssue).

Currently for occurrences this information is defined in InterpretationRemarksDefinition.

In order to make the definition more explicit we should bring it to the gbif-api project. The same mechanism is also required to identify remarks in ChecklistBank.

The idea would be to have an interface like the following:

public interface InterpretationRemark {
  Set<Term> getRelatedTerms();
}

OccurrenceIssue and NameUsageIssue would then implement it.
cgendreau pushed a commit that referenced this issue Jan 13, 2017
first part of issue #5
9b2e2c8
cgendreau pushed a commit that referenced this issue Jan 13, 2017
added related terms information to OccurrenceIssue
f1eacaf 
previously on occurrence InterpretationRemarksDefinition
see issue #5
@cgendreau cgendreau self-assigned this Jan 16, 2017
@cgendreau
Copy link
Contributor Author

NameUsageIssue fixed by 1784ade

@cgendreau cgendreau mentioned this issue Jan 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgendreau cgendreau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgendreau