Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design clean API for theories #13

Closed
c-cube opened this issue Dec 28, 2017 · 2 comments
Closed

design clean API for theories #13

c-cube opened this issue Dec 28, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@c-cube
Copy link
Collaborator

c-cube commented Dec 28, 2017

instead of exposing dirty St:

  • simplify the internals by removing Solver_types.mli
  • have a submodule for each type in Solver_types.ml
  • expose only a carefully chosen part of each module outside of Msat
@c-cube c-cube self-assigned this Dec 28, 2017
@c-cube c-cube added this to the 1.0 milestone Dec 28, 2017
@c-cube c-cube added the api label Dec 28, 2017
@Gbury
Copy link
Owner

Gbury commented Dec 29, 2017

Good idea, but I have at least one case where I manually instantiate all the functors so that I can use functions from St when defining the theory, which is useful. More precisely, using add_atom and peeking at the is_true/neg.is_true fields allows the theory to fetch the current truth value of a literal without having to maintain a separate backtrackable truth table.

@c-cube
Copy link
Collaborator Author

c-cube commented Feb 14, 2019

fixed in #11

@c-cube c-cube closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants