delay loading PICA modules in PICA::Schema to work around circular dependencies #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendencies The various modules in this dist have circular dependencies between them. This would result in PICA::Patch failing to import subs from PICA::Schema, because the sub and exporting was not set up yet by the time it would try to import. Perl would ignore the call to import when the method didn't exist. Delay loading the other PICA modules until after all parsing has been completed and exporting is set up. Future versions of perl are intending to throw errors when passing arguments to an undefined import method, which causes test failures. This also helped reveal the broken import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various modules in this dist have circular dependencies between them. This would result in PICA::Patch failing to import subs from PICA::Schema, because the sub and exporting was not set up yet by the time it would try to import. Perl would ignore the call to import when the method didn't exist.
Delay loading the other PICA modules until after all parsing has been completed and exporting is set up.
Future versions of perl are intending to throw errors when passing arguments to an undefined import method, which causes test failures. This also helped reveal the broken import.