Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put persName/ref/text() to persName/@label #6

Closed
kkrebs opened this issue May 16, 2017 · 1 comment
Closed

put persName/ref/text() to persName/@label #6

kkrebs opened this issue May 16, 2017 · 1 comment
Assignees
Milestone

Comments

@kkrebs
Copy link
Collaborator

kkrebs commented May 16, 2017

persName/ref/text() ist missing, we should use the label attribute

<persName type="TMKl-Nef">
  Türabî <ref target="pr-30522253-4">TMKl-Nef/V.ii, p. 224</ref>
</persName>
<mei:name type="TMKl-Nef" nymref="cmo_source_00002620" label="TMKl-Nef/V.ii, p. 224">Türabî</mei:name>
@kkrebs kkrebs added this to the Migrate Data milestone Sep 14, 2017
@kkrebs kkrebs added the bug label Sep 14, 2017
@kkrebs kkrebs assigned kkrebs and sebhofmann and unassigned sebhofmann and kkrebs Sep 18, 2017
@kkrebs
Copy link
Collaborator Author

kkrebs commented Sep 18, 2017

I checked if we can use solr index for this. For composer names this works, but for other name sources, like simple bibliography links we still need a label (see http://cmo.gbv.de/cmo/receive/cmo_person_00000377 or pp-21950636-8).

sebhofmann added a commit that referenced this issue Sep 18, 2017
@kkrebs kkrebs closed this as completed Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants