Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReaderObservable added #21

Merged
merged 3 commits into from
Feb 3, 2020
Merged

ReaderObservable added #21

merged 3 commits into from
Feb 3, 2020

Conversation

mlegenhausen
Copy link
Collaborator

This is mainly a port of the ReaderTask from fp-ts.

I also added MonadObservable to provide fromObservable.

@mlegenhausen mlegenhausen mentioned this pull request Jan 29, 2020
Closed
@mlegenhausen
Copy link
Collaborator Author

@gcanti any concerns left before merge?

@gcanti
Copy link
Owner

gcanti commented Jan 31, 2020

@mlegenhausen no no, feel free to merge (I thought you wanted to add something more so I was waiting)

@mlegenhausen mlegenhausen merged commit ca1ac22 into gcanti:master Feb 3, 2020
@mlegenhausen mlegenhausen deleted the reader-observable branch February 3, 2020 07:38
@mlegenhausen
Copy link
Collaborator Author

Done

@gcanti
Copy link
Owner

gcanti commented Feb 3, 2020

Thanks @mlegenhausen, going to release v0.6.6 asap

@gcanti
Copy link
Owner

gcanti commented Feb 3, 2020

Released

@mlegenhausen
Copy link
Collaborator Author

@gcanti thanks!

@waynevanson waynevanson mentioned this pull request Oct 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcanti gcanti gcanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegenhausen @gcanti