Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add W variants, closes #904 #1198

Merged
merged 1 commit into from
May 11, 2020
Merged

add W variants, closes #904 #1198

merged 1 commit into from
May 11, 2020

Conversation

gcanti
Copy link
Owner

@gcanti gcanti commented May 6, 2020 •
edited
Loading

  • New Feature
    • Either
      • add getOrElseW
      • add chainW
    • IOEither
      • add getOrElseW
      • add chainW
    • Option
      • add getOrElseW
    • Reader
      • add chainW
    • ReaderEither
      • add getOrElseW
      • add chainW
    • ReaderTaskEither
      • add getOrElseW
      • add chainW
    • StateReaderTaskEither
      • add chainW
    • TaskEither
      • add getOrElseW
      • add chainW

@gcanti gcanti added this to the 2.6 milestone May 6, 2020
@gcanti gcanti mentioned this pull request May 6, 2020
Closed
@OliverJAsh
Copy link
Collaborator

Does this also address the issues I mentioned in #1002 and #1034?

@giogonzo
Copy link
Collaborator

giogonzo commented May 6, 2020

@OliverJAsh looks like so, the PR provides getOrElseW for all data types already providing getOrElse

@gcanti gcanti merged commit 6f54e81 into 2.6 May 11, 2020
@gcanti gcanti deleted the 904 branch May 11, 2020 08:15
@SRachamim
Copy link
Contributor

SRachamim commented May 30, 2020 •
edited
Loading

FP noob here. What doesW stand for in this case? Can you please add explanation or link to a background article about those "W variants" purpose and usages? Couldn't find any information related.

@samhh
Copy link
Contributor

samhh commented May 30, 2020 •
edited
Loading

@SRachamim It stands for "widen". Its purpose is to allow you to widen/unionise in circumstances where that's helpful and was previously very unergonomic.

Like many things, this should be clearly documented somewhere. I've had to write some internal documentation for my team so that this library isn't so esoteric.

@SRachamim
Copy link
Contributor

Thanks! You helped a lot!

@devanshj devanshj mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
5 participants
@gcanti @OliverJAsh @giogonzo @SRachamim @samhh