Array, ReadonlyArray: change scanLeft & scanRight to return NonEmpty #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @willheslam, I agree. |
gcanti
requested changes
Feb 2, 2021
willheslam
force-pushed
the
scan-returns-non-empty-array
branch
from
9bb02ce
to
a864bf3
Compare
gcanti
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given scanLeft/Right, unlike reduce, always returns an array that has at least one element (the seed),
it makes sense to me to be more specific about the result.
What do you think? Are there any unintended consequences I'm missing here?