This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Webpack with Bili (a bundler based on Rollup).
Main reason is that I want to use tcomb on ObservableHQ (for notebook-based programming) via unpkg.com. It currently only includes CommonJS bundles and the
dist/
directory is missing: (see: https://unpkg.com/tcomb@3.2.29/).I've added/modified entries in
package.json
(which seems a sane default) to let unpkg.com and jsdelivr.com know where to find the bundles. Adapted from https://github.com/immerjs/immer/blob/v3.1.1/package.json. Theumd:main
output is minified for use in browsers.It adds a
bili.config.ts
where you can e.g. configure the formats. The apidocs (https://bili.egoist.sh/api/globals.html#format) say you can additionally use"cjs-min" | "es-min" | "esm-min" | "umd-min" | "iife-min" | "amd-min" | "system-min"
. Adapted from https://github.com/immerjs/immer/blob/v3.1.1/bili.config.ts.Finally I've changed
package.json
scripts to havebuild
andtest
. I think unpkg.com needs it to process the bundles and put it intodist/
for each release. I've runnpm run build
andnpm run test
and it works. Do we want to add both steps to.travis.yml
?I've also tested microbundle but Bili was better documented and configurable. Not relevant for tcomb bundle process but worth mentioning: It also does not leave annoying build cache directories used by
rollup-plugin-typescript2
(this can be also configured). Alsoiife
output option is documented and does not clash withcjs
output configuration like in microbundle. Bili is much smaller than microbundle (see "Bili vs Microbundle" issue at egoist/bili#163).