Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Update magneticAnomalyActive bool to ScriptFlags #59

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

zquestz
Copy link
Contributor

@zquestz zquestz commented Oct 16, 2018

This resolves the code debt introduced by passing the magneticAnomalyActive bool around instead of the current ScriptFlags set. This should be much cleaner to maintain for future hard forks.

@tyler-smith
Copy link
Member

tyler-smith commented Oct 17, 2018

This looks great. I made issue #60 to track the TODO items

I made a branch that abstracts all the bitmask AND mask checks into HasFlag methods. Let me know what you think, and if you think it's good we can include it in this PR if you want. https://github.com/gcash/bchd/compare/txscript...TS_txscript?expand=1

@zquestz
Copy link
Contributor Author

zquestz commented Oct 17, 2018

Your changes look great. Go ahead an throw those commits in this PR and lets merge them together =)

@tyler-smith
Copy link
Member

Cool, your changes lgtm so I'll mark it as Accepted. Merge when you and/or @cpacia think my change is ready.

@zquestz zquestz merged commit 0223fdb into master Oct 18, 2018
@zquestz zquestz deleted the txscript branch October 18, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants