Remove dependency on NodeBloom #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using NodeBloom to provide a programatic toggle to turn on and off receiving unconfirmed transactions. The alternative is a using the relay bool in the version message but this requires a full restart to make the change take affect. However, the new interface in the bchwallet mobile package is very thin and does not provide a method to toggle relay. So given this it makes sense to just remove the dependency on NodeBloom so that remote peers do not need to support NodeBloom in addition to NodeCF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using NodeBloom to provide a programatic toggle to turn on
and off receiving unconfirmed transactions. The alternative is a using the
relay bool in the version message but this requires a full restart to make
the change take effect.
However, the new interface in the bchwallet mobile package is very thin and
does not provide a method to toggle relay. So given this it makes sense to just
remove the dependency on NodeBloom so that remote peers do not need to support
NodeBloom in addition to NodeCF.