Feature/view data card schemas #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ARADDCC012
commented
Jun 25, 2024
ARADDCC012
commented
GB27247
suggested changes
Jun 28, 2024
frontend/src/schemas/SchemaList.tsx
Outdated
Comment on lines
58
to
79
| schemas.map((schema, index) => ( | ||
| <ListItem divider={index < schemas.length - 1} key={schema.id}> | ||
| <ListItemText>{schema.name}</ListItemText> | ||
| <Stack spacing={1} direction={{ xs: 'column', md: 'row' }}> | ||
| <Button size='small' variant='outlined' onClick={() => handleSetSchemaActive(schema)}> | ||
| {schema.active ? 'Mark as inactive' : 'Mark as active'} | ||
| </Button> | ||
| <Button size='small' variant='contained' onClick={() => handleDeleteSchemaButtonOnClick(schema.id)}> | ||
| Delete | ||
| </Button> | ||
| </Stack> | ||
| ))} | ||
| </Stack> | ||
| ) | ||
| }, [ | ||
| schemas, | ||
| errorMessage, | ||
| open, | ||
| schemaToBeDeleted, | ||
| handleDeleteConfirm, | ||
| handleDeleteSchemaButtonOnClick, | ||
| handleSetSchemaActive, | ||
| ]) | ||
| <MessageAlert message={errorMessage} severity='error' /> | ||
| <ConfirmationDialogue | ||
| open={open} | ||
| title='Delete schema' | ||
| onConfirm={() => handleDeleteConfirm(schemaToBeDeleted)} | ||
| onCancel={() => setOpen(false)} | ||
| errorMessage={errorMessage} | ||
| dialogMessage={ | ||
| 'Deleting this schema will break any existing models that are using it. Are you sure you want to do this?' | ||
| } | ||
| /> |
There was a problem hiding this comment.
Could we render the ConfirmationDialog outside of this mapping. Because you're mapping over many schemas when you go to delete one, it will render a ConfirmationDialog for all of them. Cause this has translucent styling it mean's it renders the whole UI opaque black for multiple schemas.
There was a problem hiding this comment.
Very good catch and sloppy work on my part. There's no reason for either the ConfirmationDialog nor MessageAlert to be in here.
GB27247
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.