-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bai 1348/mirrored model creation #1348
Conversation
frontend/src/common/PageWithTabs.tsx
Outdated
}} | ||
> | ||
<Typography justifyContent='center' align='center'> | ||
[READONLY] Mirrored from {sourceModelId} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like making it clear where the model comes from but I'm not a big fan of using a banner for this, it's in danger of being over-used. Could we include this information next to the model name at the top or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have three options, I'm noticing that the page doesn't cope well with being resized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the styling so the cards wrap around when the page is too small.
return readOnly ? ( | ||
<MessageAlert | ||
severity='warning' | ||
message='This mirrored model has no model card. Please export the model card from the source model.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I manually a model card data into the DB then I still see this message rather than the model card?
currentUserRoles={currentUserRoles} | ||
readOnly={!!model.settings.mirror?.sourceModelId} | ||
/> | ||
), | ||
disabled: !model.card, | ||
disabledText: 'Select a schema to view this tab', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still appears for mirrored models but isn't applicable since a user cannot select a schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the create entry page for a mirrored model, can you make the source model ID mandatory?
No description provided.