Add export functionality to Bailo #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m19671
reviewed
May 26, 2023
| @@ -2,7 +2,7 @@ import { getAccessToken } from '../routes/v1/registryAuth.js' | |||
| import { consoleLog } from '../utils/logger.js' | |||
|
|
|||
| async function main() { | |||
| const model = 'nginx' | |||
| const model = 'test_deployment/test_yolo' | |||
backend/src/routes/v1/export.ts
Outdated
| // Set .zip extension to request header | ||
| res.set('Content-disposition', `attachment; filename=${uuid}.zip`) | ||
| res.set('Content-Type', 'application/zip') | ||
| // res.set('Cache-Control', 'private, max-age=604800, immutable') |
backend/src/types/types.ts
Outdated
| blobSum: string | ||
| } | ||
|
|
||
| export interface ImageManifest { |
There was a problem hiding this comment.
Can probably get rid of this now as it won't be accurate or used
a3957273
commented
May 26, 2023
backend/src/routes.ts
Outdated
| @@ -100,4 +101,6 @@ server.get('/api/v1/admin/logs', ...getApplicationLogs) | |||
| server.get('/api/v1/admin/logs/build/:buildId', ...getItemLogs) | |||
| server.get('/api/v1/admin/logs/approval/:approvalId', ...getItemLogs) | |||
|
|
|||
| server.get('/api/v1/export/:uuid/:deploymentId/version/:version', ...exportModel) | |||
There was a problem hiding this comment.
We can get the uuid from the deploymentId, so we don't actually need the uuid value here.
frontend/cypress/e2e/model.cy.ts
Outdated
| @@ -147,6 +147,8 @@ describe('Model with code and binary files', () => { | |||
| cy.fixture('minimal_metadata.json').then((modelMetadata) => { | |||
| const imageName = `${registryUrl}/${deploymentUuid}/${modelUuid}:${modelMetadata.highLevelDetails.modelCardVersion}` | |||
| cy.exec(`docker login ${registryUrl} -u ${'user'} -p ${dockerPassword}`) | |||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | |||
| cy.wait(30000) | |||
There was a problem hiding this comment.
Change this to checking every x seconds with:
cy.exec('npm run build', { failOnError: false }).then((result) => {
// yields the 'result' object
// {
// code: 0,
// stdout: "Files successfully built",
// stderr: ""
// }
})
JR40159
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.