Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-2630 example real federatedstore #2631

Merged
merged 144 commits into from
Oct 25, 2022

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Apr 19, 2022

GCHQDev404 and others added 30 commits February 5, 2021 07:26
…federatedstore-federated-operation-remove-midput

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/FederatedOperation.java
GCHQDev404 and others added 7 commits October 19, 2022 21:16
…ha' into gh-2630-example-real-federatedstore

# Conflicts:
#	core/access/pom.xml
#	core/cache/pom.xml
#	core/common-util/pom.xml
#	core/data/pom.xml
#	core/exception/pom.xml
#	core/graph/pom.xml
#	core/operation/README.md
#	core/operation/pom.xml
#	core/pom.xml
#	core/serialisation/pom.xml
#	core/store/pom.xml
#	core/store/src/main/java/uk/gov/gchq/gaffer/store/Store.java
#	core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandler.java
#	core/store/src/test/java/uk/gov/gchq/gaffer/store/StoreTest.java
#	core/store/src/test/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandlerTest.java
#	core/type/pom.xml
#	example/basic/basic-model/pom.xml
#	example/basic/basic-rest/pom.xml
#	example/basic/pom.xml
#	example/federated-demo/pom.xml
#	example/pom.xml
#	example/road-traffic/pom.xml
#	example/road-traffic/road-traffic-demo/pom.xml
#	example/road-traffic/road-traffic-generators/pom.xml
#	example/road-traffic/road-traffic-model/pom.xml
#	example/road-traffic/road-traffic-rest/pom.xml
#	integration-test/pom.xml
#	library/bitmap-library/pom.xml
#	library/cache-library/hazelcast-cache-service/pom.xml
#	library/cache-library/hazelcast-cache-service/src/test/resources/hazelcast.xml
#	library/cache-library/jcs-cache-service/pom.xml
#	library/cache-library/pom.xml
#	library/flink-library/pom.xml
#	library/hdfs-library/pom.xml
#	library/pom.xml
#	library/sketches-library/pom.xml
#	library/spark/pom.xml
#	library/spark/spark-accumulo-library/pom.xml
#	library/spark/spark-library/pom.xml
#	library/time-library/pom.xml
#	pom.xml
#	rest-api/accumulo-rest/pom.xml
#	rest-api/common-rest/pom.xml
#	rest-api/common-rest/src/main/java/uk/gov/gchq/gaffer/rest/SystemProperty.java
#	rest-api/common-rest/src/main/resources/version.properties
#	rest-api/core-rest/pom.xml
#	rest-api/hbase-rest/pom.xml
#	rest-api/map-rest/pom.xml
#	rest-api/parquet-rest/pom.xml
#	rest-api/pom.xml
#	rest-api/spring-rest/pom.xml
#	store-implementation/accumulo-store/pom.xml
#	store-implementation/accumulo-store/src/main/java/uk/gov/gchq/gaffer/accumulostore/retriever/AccumuloSetRetriever.java
#	store-implementation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/operation/handler/GetElementsWithinSetHandlerTest.java
#	store-implementation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/retriever/impl/AccumuloIDWithinSetRetrieverTest.java
#	store-implementation/federated-store/pom.xml
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorageTraitsTest.java
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreGetTraitsTest.java
#	store-implementation/hbase-store/README.md
#	store-implementation/hbase-store/pom.xml
#	store-implementation/hbase-store/src/main/java/uk/gov/gchq/gaffer/hbasestore/HBaseStore.java
#	store-implementation/map-store/pom.xml
#	store-implementation/parquet-store/README.md
#	store-implementation/parquet-store/pom.xml
#	store-implementation/parquet-store/src/main/java/uk/gov/gchq/gaffer/parquetstore/ParquetStore.java
#	store-implementation/pom.xml
#	store-implementation/proxy-store/pom.xml
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2022

CLA assistant check
All committers have signed the CLA.

@GCHQDev404
Copy link
Contributor Author

blocked waiting on #2769

@GCHQDev404 GCHQDev404 marked this pull request as ready for review October 23, 2022 19:56
@GCHQDev404 GCHQDev404 added the blocked Requires other issue(s) to be resolved label Oct 23, 2022
@GCHQDev404 GCHQDev404 changed the base branch from develop to v2-alpha October 23, 2022 19:59
@GCHQDev404 GCHQDev404 changed the title Gh 2630 example real federatedstore gh-2630 example real federatedstore Oct 23, 2022
@GCHQDev404 GCHQDev404 removed the blocked Requires other issue(s) to be resolved label Oct 24, 2022
…eal-federatedstore

# Conflicts:
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreCacheBackwardCompatibilityTest.java
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreTest.java
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments + needs another commit to fix checkstyle anyway.

GCHQDev404 and others added 2 commits October 24, 2022 16:52
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
@GCHQDev404 GCHQDev404 force-pushed the gh-2630-example-real-federatedstore branch from 31574a0 to c21b654 Compare October 24, 2022 16:25
@r32575 r32575 self-requested a review October 25, 2022 09:51
@@ -0,0 +1,3 @@
{
"class": "GetAllElements"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's minor but a lot of these files are missing newlines at the end

@GCHQDev404 GCHQDev404 merged commit 20413bf into v2-alpha Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FederatedStore script to start a real FedStore without pom and generators.
8 participants