Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge function that shows which graph results come from #3118

Open
t92549 opened this issue Nov 24, 2023 · 1 comment
Open

Add merge function that shows which graph results come from #3118

t92549 opened this issue Nov 24, 2023 · 1 comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Milestone

Comments

@t92549
Copy link
Contributor

t92549 commented Nov 24, 2023

Describe the new feature you'd like
There should be a federated merge function added so that when I perform a GetElements operation, I can see which elements came from which subgraph.

Describe alternatives you've considered
It could be implemented as an option rather than a merge function.

Additional context
Results from ConcatenateMergeFunction look like this:
[el1, el2, el3]
Results from this new merge function would like something like:
{graph1: [el1, el2], graph2: [el3]}

@t92549 t92549 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Nov 24, 2023
@tb06904
Copy link
Member

tb06904 commented Nov 24, 2023

Might be worth looking at using some part of the stream library to do this as the map() method might work quite well, there is also #3075 open to investigate other features we could use too.

@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 15, 2024
wb36499 pushed a commit that referenced this issue Oct 23, 2024
* better handle cache related operations

* basic testing to ensure named ops work

* sonar smells

* whitespace

* add option to let results stay separate #3118

* add option to specify to use default graph ids

* typo

* check style

---------

Co-authored-by: p29876 <165825455+p29876@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

No branches or pull requests

3 participants