tcell panic on TERM=xterm-termite

[jangler]

Any plans to fix this? xterm-termite is what my termite uses by default, and tcell panics on it:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa48 pc=0x72cf42]

goroutine 1 [running]:
github.com/gdamore/tcell/terminfo.LookupTerminfo(0xc000018105, 0xd, 0xc000018105, 0xd, 0xcbe9207f64715fde)
	/home/brandon/src/github.com/gdamore/tcell/terminfo/terminfo.go:752 +0x102
github.com/gdamore/tcell.NewTerminfoScreen(0x7d2d01, 0x0, 0x30, 0x50)
	/home/brandon/src/github.com/gdamore/tcell/tscreen.go:44 +0x60
github.com/gdamore/tcell.NewScreen(0x7d71a0, 0xbc14c0, 0x7f4c71ec3108, 0x0)
	/home/brandon/src/github.com/gdamore/tcell/screen.go:208 +0x22
...

I see that xterm-termite had a terminfo added in 2efc922, but I guess it was lost in the fix to #301? TERM=termite works fine.

[halturin]

the same issue with tmux-256colors

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa48 pc=0x50eecf]

goroutine 1 [running]:
github.com/gdamore/tcell/terminfo.LookupTerminfo(0xc000018165, 0xd, 0xc000018165, 0xd, 0x63ac60)
        /home/taras/devel/goenv/src/github.com/gdamore/tcell/terminfo/terminfo.go:752 +0x10f
github.com/gdamore/tcell.NewTerminfoScreen(0xc00013dd90, 0x7bbf10, 0x64a960, 0xc00013dd90)
        /home/taras/devel/goenv/src/github.com/gdamore/tcell/tscreen.go:44 +0x65
github.com/gdamore/tcell.NewScreen(0x8, 0x63ac60, 0x1, 0x0)
        /home/taras/devel/goenv/src/github.com/gdamore/tcell/screen.go:208 +0x25
main.run()
        /home/taras/devel/goenv/src/github.com/gokcehan/lf/client.go:19 +0x4e
main.main()
        /home/taras/devel/goenv/src/github.com/gokcehan/lf/main.go:269 +0xbb8
❯❯❯❯ echo $TERM                                                                                                                                                                         ~/D/development
tmux-256color

[gdamore]

I will fix, I just haven't had enough time to look at it yet. Probably in the next day or two.

[gdamore]

There are two problems here.

1. The crash is due to a big mishandling the non-existent terminal description.
2. The terminal descriptions that should be there aren't.

Stay tuned.

[gdamore]

tmux-256color must not be defined in your terminfo -- likewise xterm-termite.

They are not in my terminfo, and that's probably part of the problem.

[halturin]

without tmux-256color italic font doesn't work in my vim. my default TERM is xterm-256color (outside of the tmux) and everything works well. I would appreciate if you give me some advice or workaround to fix this issue without losing italic lettering

[gdamore]

That sounds like a vim problem. Not tcell. Get Outlook<https://aka.ms/qtex0l> for iOS

…

________________________________ From: Taras Halturin <notifications@github.com> Sent: Wednesday, October 14, 2020 3:29:21 AM To: gdamore/tcell <tcell@noreply.github.com> Cc: gdamore <garrett@damore.org>; State change <state_change@noreply.github.com> Subject: Re: [gdamore/tcell] tcell panic on TERM=xterm-termite (#391) without tmux-256color italic font doesn't work in my vim. my default TERM is xterm-256color (outside of the tmux) and everything works well. I would appreciate if you give me some advice or workaround to fix this issue without losing italic lettering — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<#391 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJ4G7LXQYDJUXOKPW6JWVDSKV4QDANCNFSM4SCW6EKA>.