Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate config for Firebase & update dependencies #66

Merged
merged 4 commits into from
Mar 27, 2021
Merged

Add separate config for Firebase & update dependencies #66

merged 4 commits into from
Mar 27, 2021

Conversation

kartikderasari
Copy link
Contributor

  • Add separate config file for Firebase
  • Update config file path in documentation
  • Update dependencies

@agarwalbharat
Copy link
Member

Looks good to me, Thanks for the Help,

Fixes: gdg-x/aura#80

PS: Need to add this config firebase-config.js in .gitignore, I will do that..

@agarwalbharat agarwalbharat added the enhancement New feature or request label Mar 27, 2021
@agarwalbharat agarwalbharat self-assigned this Mar 27, 2021
@agarwalbharat agarwalbharat merged commit a00b977 into gdg-x:dev-2021 Mar 27, 2021
@agarwalbharat agarwalbharat mentioned this pull request Mar 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwalbharat agarwalbharat agarwalbharat approved these changes

Assignees

@agarwalbharat agarwalbharat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikderasari @agarwalbharat